Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Ember 1.5.0, updates ember-data also #886

Merged
merged 1 commit into from
Apr 1, 2014

Conversation

bantic
Copy link
Contributor

@bantic bantic commented Mar 24, 2014

  • ember 1.5.0-beta.4
  • ember-data 1.0.0-beta.7
  • jquery 2.1.0
  • All tests pass: 5330afc600779133610fc942

@passy
Copy link
Member

passy commented Mar 24, 2014

Thanks for the update, but we're gonna hold off to merging this until the release is stable. Kudos for running the test suite! :)

Could you update this once 1.5 is released?

@bantic
Copy link
Contributor Author

bantic commented Mar 24, 2014

@passy Sure, I believe it will be released in 2 weeks. I can also switch to Ember 1.4.0 (stable) right now if that's better.

@sindresorhus
Copy link
Member

@bantic thanks for the update. we can wait on 1.5 :)

@@ -3,10 +3,10 @@
"version": "0.0.0",
"dependencies": {
"todomvc-common": "~0.1.4",
"jquery": "~2.1.0",
"jquery": "2.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

@bantic bantic changed the title Update to Ember 1.5.0-beta.4, updates ember-data also Update to Ember 1.5.0, updates ember-data also Mar 31, 2014
@bantic
Copy link
Contributor Author

bantic commented Mar 31, 2014

updated to Ember 1.5.0 stable. lots of new stuff in ember: emberjs/ember.js@v1.4.0...v1.5.0

cc @passy @sindresorhus

@@ -5,8 +5,8 @@
"todomvc-common": "~0.1.4",
"jquery": "~2.1.0",
"handlebars": "~1.3.0",
"ember": "~1.3.1",
"ember-data": "1.0.0-beta.6",
"ember": "1.5.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use "~" here?

  * ember 1.5.0-beta.4
  * ember-data 1.0.0-beta.7
  * jquery 2.1.0
  * All tests pass: http://monosnap.com/image/Li8mF3s891Zkoo76yV46BbAqFjs77O
@bantic
Copy link
Contributor Author

bantic commented Apr 1, 2014

this now uses "~1.5.0" for the bower.json ember version

sindresorhus added a commit that referenced this pull request Apr 1, 2014
Update to Ember 1.5.0, updates ember-data also
@sindresorhus sindresorhus merged commit 7e3db80 into tastejs:gh-pages Apr 1, 2014
@sindresorhus
Copy link
Member

Awesome. Thanks for the update @bantic :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants