Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understand CSP for style and ensure it doesnt break while developing #230

Open
dennyabrain opened this issue Mar 9, 2023 · 1 comment
Open
Assignees
Labels
enhancement New feature or request plugin

Comments

@dennyabrain
Copy link
Contributor

We had a CSP entry for style-src that looked like this

style-src https://fonts.googleapis.com 'sha256-47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=' 'sha256-o7bYsu5iNiTxIObyslerFNZrDfkROYhElKhuOItXvVk=' 'sha256-ymN5q6v7MB6PygHnN3N59Z0O74H6pvF05DOnMn25Xvg='; 

I have noticed that whenever we make changes or add new features to the plugin, the UI for the plugin breaks. I am guessing because whatever that sha is supposed to denote changes when you modify the source code of the plugin. We were defaulting to completely removing CSP during development, which is of course non ideal.

To be able to proceed for now, we've updated the csp to contain this
style-src https://fonts.googleapis.com 'self' 'unsafe-inline

I would like us to understand and document how CSP for style works. And what we can do to ensure we stay secure without breaking the plugin UI as new features are added.

@dennyabrain dennyabrain added enhancement New feature or request plugin labels Mar 9, 2023
dennyabrain added a commit that referenced this issue Mar 9, 2023
This is a tentative fix. Check #230
@Bhargav-Dave Bhargav-Dave self-assigned this Mar 31, 2023
@Bhargav-Dave
Copy link
Contributor

@duggalsu Had a few inputs on the same, they can link some documentation on the same here, I will take up the issue after the same

duggalsu pushed a commit that referenced this issue Oct 24, 2023
This is a tentative fix. Check #230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin
Projects
None yet
Development

No branches or pull requests

2 participants