Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(window-state): manual default implentation #425

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jun 7, 2023

No description provided.

@amrbashir amrbashir marked this pull request as ready for review June 7, 2023 12:08
@amrbashir amrbashir requested a review from a team as a code owner June 7, 2023 12:08
@FabianLars
Copy link
Member

Wouldn't this cause the same issue in 421 but for undecorated windows?

Also, as far as i can see 421 will trigger the else branch because there's no existing config for that label, no?

(p.s. #424)

@amrbashir
Copy link
Member Author

with your fix, it should work correctly

@amrbashir amrbashir changed the title fix(window-state): manual default implentation, closes #421 fix(window-state): manual default implentation Jun 7, 2023
@amrbashir amrbashir merged commit 417c85a into v1 Jun 13, 2023
@amrbashir amrbashir deleted the fix/window-state/default-impl branch June 13, 2023 12:48
amrbashir added a commit that referenced this pull request Jun 13, 2023
* fix(window-state): manual default implentation, closes #421

* Update lib.rs
amrbashir added a commit that referenced this pull request Jun 13, 2023
* fix(window-state): correctly set decoration state if no saved state exists, fixes #421 (#424)

* fix(window-state): propagate promise (#435)

closes #432

* fix(window-state): manual default implentation (#425)

* fix(window-state): manual default implentation, closes #421

* Update lib.rs

* change file

* generated files

* fix symlinks?

---------

Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
OrIOg pushed a commit to OrIOg/plugins-workspace that referenced this pull request Jun 25, 2023
* fix(window-state): manual default implentation, closes tauri-apps#421

* Update lib.rs
lucasfernog added a commit that referenced this pull request Jul 19, 2023
Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: FabianLars <fabianlars@fabianlars.de>
Co-authored-by: FabianLars <FabianLars@users.noreply.github.com>
Co-authored-by: Alexandre Dang <124160233+vdang-crabnebula@users.noreply.github.com>
Co-authored-by: Ludea <ludovicw35@hotmail.com>
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: Duke Jones <104690+dukejones@users.noreply.github.com>
Co-authored-by: NaokiM03 <37442712+NaokiM03@users.noreply.github.com>
Co-authored-by: Thibault <thibault_poisson@orange.fr>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: David Blythe <49919035+writeDavid@users.noreply.github.com>
Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
fix(stronghold): change wrong argument name for `remove` (#422)
fix(window-state): correctly set decoration state if no saved state exists, fixes #421 (#424)
fix(stronghold): return null if there is no record (#129)
fix(window-state): propagate promise (#435)
closes #432
fix(window-state): manual default implentation (#425)
fix(window-state): manual default implentation, closes #421
fix(deps): update rust crate iota-crypto to 0.21 (#438)
fix readme example (#447)
fix: handle recursive directory correctly (#455)
fix(deps): update rust crate sqlx to 0.7. plugin-sql msrv is now 1.65 (#464)
fix(persisted-scope): separately save asset protocol patterns (#459)
fix(deps): update rust crate iota-crypto to 0.22 (#475)
fix(deps): update tauri monorepo to v1.4.0 (#482)
resolve to v15.1.0 (#489)
fix(deps): update rust crate iota-crypto to 0.23 (#495)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants