feat: update to alpha.17, typed mobile plugin IPC arguments #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
lucasfernog
changed the title
amrbashir
reviewed
Oct 29, 2023
| @@ -511,7 +511,7 @@ mod tests { | |||
| assert_eq!(String::from_utf8(output.stdout).unwrap(), ""); | |||
| assert_eq!( | |||
| String::from_utf8(output.stderr).unwrap(), | |||
| "cat: test/: Is a directory\n" | |||
| "cat: test/: Is a directory\n\n" | |||
There was a problem hiding this comment.
does that sound okay? why does it have two new lines?
There was a problem hiding this comment.
the std one only gives us a single \n so it's a bug on our end (it was already a bug, since it had a \n where it shouldn't, I guess someone just fixed the test instead of the actual bug). We should track this on the tauri repo (v1 and v2).
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
amrbashir
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the in progress typed IPC arguments that will be released on alpha.17.
Needs tauri-apps/tauri#8076