Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat macOS custom protocol as https for WebRTC #1550

Closed
lemarier opened this issue Apr 20, 2021 · 0 comments · Fixed by #1551
Closed

Treat macOS custom protocol as https for WebRTC #1550

lemarier opened this issue Apr 20, 2021 · 0 comments · Fixed by #1551
Assignees
@lemarier
Labels
type: bug

Comments

@lemarier
Copy link
Member

Describe the bug
macOS custom protocol should be treated as HTTPS.

To Reproduce
N/A

Expected behavior
WebRTC should be enabled on custom protocol when permissions are granted.

Additional context
Linked with tauri-apps/wry#85 (comment)

localhost should be used as a custom protocol host in macOS. Instead of using tauri:// we should use tauri://localhost/ as a base.
@lemarier lemarier self-assigned this Apr 20, 2021
@lemarier lemarier changed the title Threat macOS custom protocol as https for WebRTC Treat macOS custom protocol as https for WebRTC Apr 20, 2021
lemarier added a commit that referenced this issue Apr 20, 2021
@lemarier
fix(custom-protocol): Make sure custom protocol is handled as secure …
b928673 
…content on macOS

Do not seems to affect other platform need to test on Windows and linux to be sure it didn’t break anything.

Fix #1550
@lemarier lemarier mentioned this issue Apr 20, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lemarier lemarier

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure custom protocol is handled as secure context on macOS tauri-apps/tauri
1 participant
@lemarier