Init PR #1
Closed
Init PR #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbarlow12
added a commit
that referenced
this pull request
Nov 17, 2018
* initial readme and fix appveyor to only deploy on tags * fix appveyor file * Remove console app from solution * start adding in files to same project. structuring by directory * Built and ran unit tests with restructured project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this is mainly for learning purposes, I wanted an easy way to get comments and feedback from people, so I just wiped the repo and did one big PR into an empty master branch.
I appreciate any feedback you can give me, as brutal as you want to be and with whatever time you can spare. I just want to learn.
A lot of this was trying to follow some design patterns that will potentially make this easily scalable to other applications besides Trello (that's all I've implemented so far).
I'm nowhere near done, but I have run through some policies that work, so I thought it would be a good point to push something up and get some feedback.
Probably will be easier if you just clone it and look at it all locally. As you can see from the PR, it's 52 changed files...
Thank you again for taking any time at all to look at this. Feel free to comment with any questions so I can make things more clear.