Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phase on some negative module tests #3832

Merged
merged 2 commits into from
Jun 10, 2023
Merged

Fix phase on some negative module tests #3832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d2bb4d
Fix phase on some module tests
jedel1043 May 22, 2023
f3f10f8
Merge branch 'main' into fix-resolution-phase
jedel1043 Jun 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/language/module-code/instn-iee-err-ambiguous-as.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,11 @@ info: |
SameValue(resolution.[[BindingName]],
starResolution.[[BindingName]]) is false, return "ambiguous".
negative:
phase: runtime
phase: resolution
type: SyntaxError
flags: [module]
---*/

$DONOTEVALUATE();

export { x as y } from './instn-iee-err-ambiguous_FIXTURE.js';
4 changes: 3 additions & 1 deletion test/language/module-code/instn-iee-err-ambiguous.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,11 @@ info: |
SameValue(resolution.[[BindingName]],
starResolution.[[BindingName]]) is false, return "ambiguous".
negative:
phase: runtime
phase: resolution
type: SyntaxError
flags: [module]
---*/

$DONOTEVALUATE();

export { x } from './instn-iee-err-ambiguous_FIXTURE.js';
4 changes: 3 additions & 1 deletion test/language/module-code/instn-iee-err-circular-as.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,11 @@ info: |
i. Assert: this is a circular import request.
ii. Return null.
negative:
phase: runtime
phase: resolution
type: SyntaxError
flags: [module]
---*/

$DONOTEVALUATE();

export { x as y } from './instn-iee-err-circular_FIXTURE.js';
4 changes: 3 additions & 1 deletion test/language/module-code/instn-iee-err-circular.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,11 @@ info: |
i. Assert: this is a circular import request.
ii. Return null.
negative:
phase: runtime
phase: resolution
type: SyntaxError
flags: [module]
---*/

$DONOTEVALUATE();

export { x } from './instn-iee-err-circular_FIXTURE.js';
4 changes: 3 additions & 1 deletion test/language/module-code/instn-iee-err-dflt-thru-star-as.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@ info: |
b. Throw a SyntaxError exception.
c. NOTE A default export cannot be provided by an export *.
negative:
phase: runtime
phase: resolution
type: SyntaxError
flags: [module]
---*/

$DONOTEVALUATE();

export { default as x } from './instn-iee-err-dflt-thru-star-int_FIXTURE.js';
4 changes: 3 additions & 1 deletion test/language/module-code/instn-iee-err-dflt-thru-star.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@ info: |
b. Throw a SyntaxError exception.
c. NOTE A default export cannot be provided by an export *.
negative:
phase: runtime
phase: resolution
type: SyntaxError
flags: [module]
---*/

$DONOTEVALUATE();

export { default } from './instn-iee-err-dflt-thru-star-int_FIXTURE.js';
4 changes: 3 additions & 1 deletion test/language/module-code/instn-iee-err-not-found-as.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@ info: |
[...]
11. Return starResolution.
negative:
phase: runtime
phase: resolution
type: SyntaxError
flags: [module]
---*/

$DONOTEVALUATE();

export { x as y } from './instn-iee-err-not-found-empty_FIXTURE.js';
4 changes: 3 additions & 1 deletion test/language/module-code/instn-iee-err-not-found.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@ info: |
[...]
11. Return starResolution.
negative:
phase: runtime
phase: resolution
type: SyntaxError
flags: [module]
---*/

$DONOTEVALUATE();

export { x } from './instn-iee-err-not-found-empty_FIXTURE.js';
4 changes: 3 additions & 1 deletion test/language/module-code/instn-named-err-ambiguous-as.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,11 @@ info: |
SameValue(resolution.[[BindingName]],
starResolution.[[BindingName]]) is false, return "ambiguous".
negative:
phase: runtime
phase: resolution
type: SyntaxError
flags: [module]
---*/

$DONOTEVALUATE();

import { x as y } from './instn-named-err-ambiguous_FIXTURE.js';
4 changes: 3 additions & 1 deletion test/language/module-code/instn-named-err-ambiguous.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,11 @@ info: |
SameValue(resolution.[[BindingName]],
starResolution.[[BindingName]]) is false, return "ambiguous".
negative:
phase: runtime
phase: resolution
type: SyntaxError
flags: [module]
---*/

$DONOTEVALUATE();

import { x } from './instn-named-err-ambiguous_FIXTURE.js';
4 changes: 3 additions & 1 deletion test/language/module-code/instn-named-err-dflt-thru-star-as.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@ info: |
b. Throw a SyntaxError exception.
c. NOTE A default export cannot be provided by an export *.
negative:
phase: runtime
phase: resolution
type: SyntaxError
flags: [module]
---*/

$DONOTEVALUATE();

import { default as x } from './instn-named-err-dflt-thru-star-int_FIXTURE.js';
4 changes: 3 additions & 1 deletion test/language/module-code/instn-named-err-dflt-thru-star-dflt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@ info: |
b. Throw a SyntaxError exception.
c. NOTE A default export cannot be provided by an export *.
negative:
phase: runtime
phase: resolution
type: SyntaxError
flags: [module]
---*/

$DONOTEVALUATE();

import x from './instn-named-err-dflt-thru-star-int_FIXTURE.js';
4 changes: 3 additions & 1 deletion test/language/module-code/instn-named-err-not-found-as.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@ info: |
[...]
11. Return starResolution.
negative:
phase: runtime
phase: resolution
type: SyntaxError
flags: [module]
---*/

$DONOTEVALUATE();

import { x as y } from './instn-named-err-not-found-empty_FIXTURE.js';
4 changes: 3 additions & 1 deletion test/language/module-code/instn-named-err-not-found-dflt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@ info: |
[...]
11. Return starResolution.
negative:
phase: runtime
phase: resolution
type: SyntaxError
flags: [module]
---*/

$DONOTEVALUATE();

import x from './instn-named-err-not-found-empty_FIXTURE.js';
4 changes: 3 additions & 1 deletion test/language/module-code/instn-named-err-not-found.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@ info: |
[...]
11. Return starResolution.
negative:
phase: runtime
phase: resolution
type: SyntaxError
flags: [module]
---*/

$DONOTEVALUATE();

import { x } from './instn-named-err-not-found-empty_FIXTURE.js';
4 changes: 3 additions & 1 deletion test/language/module-code/instn-star-err-not-found.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,11 @@ info: |
i. Let resolution be ? module.ResolveExport(name, « », « »).
ii. If resolution is null, throw a SyntaxError exception.
negative:
phase: runtime
phase: resolution
type: SyntaxError
flags: [module]
---*/

$DONOTEVALUATE();

import * as ns from './instn-star-err-not-found-faulty_FIXTURE.js';