Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase/element ios 1.11.1 #869

Merged
merged 232 commits into from
Sep 12, 2023
Merged

Rebase/element ios 1.11.1 #869

merged 232 commits into from
Sep 12, 2023

Conversation

NicolasBuquet
Copy link
Contributor

Fix #865

Anderas and others added 30 commits April 18, 2023 12:45
…n_icon

Fix: Calculation of the frame for a component of a bubble
…ds_suggestion_list

Slash commands suggestion list
…on_emoji

Disable accessibility for emojis during verification
pixlwave and others added 26 commits August 15, 2023 11:10
…ation_for_oidc

Hide deactivate account if the auth property is present on the WK.
…ing_to_3pid_changes

Hide Add Email UI according to the 3 pid changes capability
…t_cell_for_oidc

Manage account through MAS if available
Open MAS Web page when logging out from other sessions on OIDC authenticated homeservers
…out_confirmation_dialogues

Sign out through MAS redirect confirmation alerts
@NicolasBuquet NicolasBuquet added the enhancement New feature or request label Sep 12, 2023
Podfile.lock Show resolved Hide resolved
Btchap/Config/BuildSettings.swift Show resolved Hide resolved
DevTchap/Config/BuildSettings.swift Show resolved Hide resolved
Comment on lines 2593 to 2611
UIWindow *window = [[UIApplication sharedApplication] keyWindow];

if (!launchAnimationContainerView && window)
{
MXLogDebug(@"[AppDelegate] showLaunchAnimation");

MXSession *mainSession = self.mxSessions.firstObject;
LaunchLoadingView *launchLoadingView = [LaunchLoadingView instantiateWithStartupProgress:mainSession.startupProgress];

launchLoadingView.frame = window.bounds;
[launchLoadingView updateWithTheme:ThemeService.shared.theme];
launchLoadingView.autoresizingMask = UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;

[window addSubview:launchLoadingView];

launchAnimationContainerView = launchLoadingView;

[MXSDKOptions.sharedInstance.profiler startMeasuringTaskWithName:MXTaskProfileNameStartupLaunchScreen];
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on peut récupérer la mise à jour du code et le commenter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne pense pas. On n'a pas d'animation de lancement dans Tchap.

Comment on lines 5294 to 5353
- (void)roomInputToolbarView:(MXKRoomInputToolbarView *)toolbarView sendCommand:(NSString *)commandText
{
// Create before sending the message in case of a discussion (direct chat)
MXWeakify(self);
[self createDiscussionIfNeeded:^(BOOL readyToSend) {
MXStrongifyAndReturnIfNil(self);

if (readyToSend) {
if (![self sendAsIRCStyleCommandIfPossible:commandText])
{
// Display an error for unknown command
UIAlertController *alert = [UIAlertController alertControllerWithTitle:nil
message:[VectorL10n roomCommandErrorUnknownCommand]
preferredStyle:UIAlertControllerStyleAlert];
[alert addAction:[UIAlertAction actionWithTitle:[VectorL10n ok] style:UIAlertActionStyleDefault handler:nil]];
[self presentViewController:alert animated:YES completion:nil];
}
}
}];
}

- (void)roomInputToolbarViewShowSendMediaActions:(MXKRoomInputToolbarView *)toolbarView
{
NSMutableArray *actionItems = [NSMutableArray new];
if (RiotSettings.shared.roomScreenAllowMediaLibraryAction)
{
[actionItems addObject:@(ComposerCreateActionPhotoLibrary)];
}
if (RiotSettings.shared.roomScreenAllowStickerAction && !self.isNewDirectChat)
{
[actionItems addObject:@(ComposerCreateActionStickers)];
}
if (RiotSettings.shared.roomScreenAllowFilesAction)
{
[actionItems addObject:@(ComposerCreateActionAttachments)];
}
if (RiotSettings.shared.enableVoiceBroadcast && !self.isNewDirectChat)
{
[actionItems addObject:@(ComposerCreateActionVoiceBroadcast)];
}
if (BuildSettings.pollsEnabled && self.displayConfiguration.sendingPollsEnabled && !self.isNewDirectChat)
{
[actionItems addObject:@(ComposerCreateActionPolls)];
}
if (BuildSettings.locationSharingEnabled && !self.isNewDirectChat)
{
[actionItems addObject:@(ComposerCreateActionLocation)];
}
if (RiotSettings.shared.roomScreenAllowCameraAction)
{
[actionItems addObject:@(ComposerCreateActionCamera)];
}

self.composerCreateActionListBridgePresenter = [[ComposerCreateActionListBridgePresenter alloc] initWithActions:actionItems
wysiwygEnabled:RiotSettings.shared.enableWysiwygComposer
textFormattingEnabled:RiotSettings.shared.enableWysiwygTextFormatting];
self.composerCreateActionListBridgePresenter.delegate = self;
[self.composerCreateActionListBridgePresenter presentFrom:self animated:YES];
}
>>>>>>> v1.11.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On peut reprendre le code et le commenter

Copy link
Contributor Author

@NicolasBuquet NicolasBuquet Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le code est présent et commenté.

Comment on lines 3159 to 3166
else if (section == SECTION_TAG_ACCOUNT)
{
switch(row) {
case ACCOUNT_MANAGE_INDEX:
[self onManageAccountTap];
break;
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A commenter au lieu de supprimer

Copy link
Contributor Author

@NicolasBuquet NicolasBuquet Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rajouté dans la Fix PR suivante #872

Comment on lines 4165 to 4169
- (void)onManageAccountTap
{
NSURL *url = [NSURL URLWithString: self.mainSession.homeserverWellknown.authentication.account];
if (url) {
[UIApplication.sharedApplication openURL:url options:@{} completionHandler:nil];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A commenter au lieu de supprimer

Copy link
Contributor Author

@NicolasBuquet NicolasBuquet Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rajouté dans la Fix PR suivante #872

Tchap/Config/BuildSettings.swift Show resolved Hide resolved
RiotNSE/BuildSettings.swift Show resolved Hide resolved
RiotShareExtension/BuildSettings.swift Show resolved Hide resolved
@NicolasBuquet NicolasBuquet merged commit 17f4944 into develop Sep 12, 2023
1 of 2 checks passed
@NicolasBuquet NicolasBuquet deleted the rebase/element-ios-1.11.1 branch September 12, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS Rebase Element 1.11.1