Merge pull request #11 from Aswin-Vijayan/master

added tags to asg
techiescamp · Jul 22, 2023 · 4708cb9 · 4708cb9
2 parents 6fbae15 + 1a3058f
commit 4708cb9
Show file tree

Hide file tree

Showing 5 changed files with 46 additions and 2 deletions.
diff --git a/environments/dev/lb-asg/main.tf b/environments/dev/lb-asg/main.tf
@@ -36,11 +36,13 @@ module "lb-asg" {
   key_name                        = var.key_name
   vpc_id                          = var.vpc_id
   subnets                         = var.subnets
+  security_group_ids              = var.security_group_ids
   public_access                   = var.public_access
   user_data                       = var.user_data
   max_size                        = var.max_size
   min_size                        = var.min_size
   desired_capacity                = var.desired_capacity
+  propagate_at_launch             = var.propagate_at_launch
   owner                           = var.owner
   environment                     = var.environment
   cost_center                     = var.cost_center

diff --git a/environments/dev/lb-asg/variables.tf b/environments/dev/lb-asg/variables.tf
@@ -165,6 +165,11 @@ variable "subnets" {
   type        = list(string)
 }
 
+variable "security_group_ids" {
+  type        = list(string)
+  description = "Security group id of the ec2 instance"
+}
+
 variable "public_access" {
   description = "Whether the instance is public or not"
   type        = bool
@@ -190,6 +195,11 @@ variable "desired_capacity" {
   type        = number
 }
 
+variable "propagate_at_launch" {
+  description = "To enable ot disable propagate_at_launch"
+  type        = bool
+}
+
 variable "owner" {
   type        = string
   description = "Name of owner"

diff --git a/modules/lb-asg/main.tf b/modules/lb-asg/main.tf
@@ -161,8 +161,28 @@ resource "aws_autoscaling_group" "application_asg" {
 
   tag {
     key                 = "Name"
-    value               = "petclinic"
-    propagate_at_launch = true
+    value               = "${var.environment}-${var.application}-asg"
+    propagate_at_launch = var.propagate_at_launch
+  }
+  tag {
+    key                 = "Owner"
+    value               = var.owner
+    propagate_at_launch = var.propagate_at_launch
+  }
+  tag {
+    key                 = "Environment"
+    value               = var.environment
+    propagate_at_launch = var.propagate_at_launch
+  }
+  tag {
+    key                 = "CostCenter"
+    value               = var.cost_center
+    propagate_at_launch = var.propagate_at_launch
+  }
+  tag {
+    key                 = "Application"
+    value               = var.application
+    propagate_at_launch = var.propagate_at_launch
   }
 
 }

diff --git a/modules/lb-asg/variables.tf b/modules/lb-asg/variables.tf
@@ -165,6 +165,11 @@ variable "subnets" {
   type        = list(string)
 }
 
+variable "security_group_ids" {
+  type        = list(string)
+  description = "Security group id of the ec2 instance"
+}
+
 variable "public_access" {
   description = "Whether the instance is public or not"
   type        = bool
@@ -190,6 +195,11 @@ variable "desired_capacity" {
   type        = number
 }
 
+variable "propagate_at_launch" {
+  description = "To enable ot disable propagate_at_launch"
+  type        = bool
+}
+
 variable "owner" {
   type        = string
   description = "Name of owner"

diff --git a/vars/dev/lb-asg.tfvars b/vars/dev/lb-asg.tfvars
@@ -43,6 +43,7 @@ instance_type                    = "t2.medium"
 key_name                         = "aswin-key"
 vpc_id                           = "vpc-0a5ca4a92c2e10163"
 subnets                          = ["subnet-058a7514ba8adbb07", "subnet-0dbcd1ac168414927", "subnet-032f5077729435858"]
+security_group_ids               = ["sg-056e31eec8fdb151f"]
 public_access                    = true
 
 #user_data
@@ -55,6 +56,7 @@ user_data                        = <<-EOF
 max_size                         = 1
 min_size                         = 1
 desired_capacity                 = 1
+propagate_at_launch              = true
 
 #tags
 owner                            = "techiescamp-devops"