Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for server name #1476

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

MichaelSun90
Copy link
Contributor

We have serverName in connection configuration, but the logic for actually using it config the cn name is missing. This PR added the logic. #1388

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1476 (838a8c1) into master (5015634) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1476      +/-   ##
==========================================
- Coverage   80.50%   80.41%   -0.10%     
==========================================
  Files          91       91              
  Lines        4669     4673       +4     
  Branches      856      858       +2     
==========================================
- Hits         3759     3758       -1     
- Misses        634      637       +3     
- Partials      276      278       +2     
Impacted Files Coverage Δ
src/connection.ts 64.78% <0.00%> (-0.36%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

*
* (no default)
*/
serverName?: string;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit: Use servername instead, that would match the option name used by Node.js.

@MichaelSun90
Copy link
Contributor Author

Hi @arthurschreiber , Just checked with David, for JDBC, then actually accept what user provided server name as a higher priority choice compare to server name from the routing. There also some other driver that will try to connect with both and connection with whichever connected successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants