Skip to content

Commit

Permalink
Correct missing field(s) error
Browse files Browse the repository at this point in the history
  • Loading branch information
GregDritschler authored and tekton-robot committed Mar 27, 2020
1 parent 543f5a5 commit 2ed4b85
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
5 changes: 2 additions & 3 deletions pkg/apis/pipeline/v1alpha1/pipeline_validation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,8 @@ func TestPipeline_Validate(t *testing.T) {
)),
failureExpected: true,
}, {
name: "pipeline spec missing",
p: tb.Pipeline("pipeline", "namespace",
),
name: "pipeline spec missing",
p: tb.Pipeline("pipeline", "namespace"),
failureExpected: true,
}, {
name: "pipeline spec invalid (duplicate tasks)",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,7 @@ func TestResourceValidation_Invalid(t *testing.T) {
want: apis.ErrInvalidValue("spec.type", "not-supported"),
}, {
name: "missing spec",
res: &v1alpha1.PipelineResource{
},
res: &v1alpha1.PipelineResource{},
want: apis.ErrMissingField("spec.type"),
},
}
Expand Down

0 comments on commit 2ed4b85

Please sign in to comment.