-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix Windows image entrypoint paths for parity with Linux
Tekton expects to find the entrypoint binary in '/ko-app/entrypoint' which is equivalent to 'C:\ko-app\entrypoint' on Windows. See 'pkg/pod/entrypoint.go:orderContainers()'. Currently entrypoint is stored in 'C:\ProgramData\tektoncd\pipeline\entrypoint.exe' causing this to break on Windows. To avoid the need for platform-specific logic in the controller, and for parity with Linux, this change updates 'entrypoint' and 'nop' images for Windows to store binaries in 'C:\ko-app\'.
- Loading branch information
1 parent
4307afc
commit ff0fbc8
Showing
2 changed files
with
6 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters