fix: ALTER TABLE result output #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekumara
changed the title
|
Thanks for this. I've moved the test into |
tekumara
pushed a commit
that referenced
this pull request
Jun 7, 2024
🤖 I have created a release *beep* *boop* --- ## [0.9.15](v0.9.14...v0.9.15) (2024-06-07) ### Bug Fixes * ALTER TABLE result output ([#100](#100)) ([3e0e236](3e0e236)) ### Chores * **deps-dev:** bump pyright from 1.1.361 to 1.1.366 ([#102](#102)) ([81839a4](81839a4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: potatobot-prime[bot] <132267321+potatobot-prime[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fwiw, I'm attempting to use fakesnow to test alembic migrations of snowflake 😬.
You already have a test for
alter table, but sqlalchemy (versus the raw cursor) always calls.descriptionon the results of queries and it was hitting similar issues to issues you've already solved with e.g.CREATE TABLEetc.I deviated from the pattern a little bit because
AlterTableconstructs returnedALTERTABLEas thecmd. It seemed somewhat unfortunate to compare exactly against that, but also seemed very likely that other ALTER statements would have the same generic output.