Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

constants.DEFAULT_ATTRIBUTE_TYPE is changed to Text #813

Merged
merged 4 commits into from
Feb 1, 2024
Merged

constants.DEFAULT_ATTRIBUTE_TYPE is changed to Text #813

merged 4 commits into from
Feb 1, 2024

Conversation

KeshavSoni2511
Copy link
Contributor

Fix for issue #810

@pooja1pathak pooja1pathak mentioned this pull request Jan 31, 2024
Closed
@fgalan
Copy link
Member

fgalan commented Jan 31, 2024

Suggestion:

  1. Create a PR at iotagent-node-lib fixing the functional test in that PR
  2. In this PR (iota-json) modificy packages.json iotagent-node-lib dependency to pint to the fork repository and branch used in the PR in step 1

@AlvaroVega
Copy link
Member

Maybe a twing PR for iotagent-ul applies ?
https://github.com/telefonicaid/iotagent-ul/blob/522990859c9e607c024bc85a81f23bbb3d9650f6/lib/constants.js#L40

@fgalan
Copy link
Member

fgalan commented Feb 1, 2024

Maybe a twing PR for iotagent-ul applies ? https://github.com/telefonicaid/iotagent-ul/blob/522990859c9e607c024bc85a81f23bbb3d9650f6/lib/constants.js#L40

I think so.

@Keshav-NEC could you do in iotagent-ul repository a twin PR as @AlvaroVega suggests, please?

fgalan
fgalan reviewed Feb 1, 2024
View reviewed changes
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
@KeshavSoni2511 @fgalan
Update CHANGES_NEXT_RELEASE
ab59c20 
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
@KeshavSoni2511
Copy link
Contributor Author

@Keshav-NEC could you do in iotagent-ul repository a twin PR as @AlvaroVega suggests, please?

Hi @fgalan, we are working on it.

@pooja1pathak pooja1pathak mentioned this pull request Feb 1, 2024
Closed
fgalan
fgalan reviewed Feb 1, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@KeshavSoni2511 @fgalan
Update package.json
5f6fc33 
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
fgalan
fgalan approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@fgalan fgalan merged commit e2cd004 into telefonicaid:master Feb 1, 2024
6 of 7 checks passed
@fgalan fgalan mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KeshavSoni2511 @fgalan @AlvaroVega