Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert updates to protocol/message data types #253

Merged
merged 20 commits into from
Jan 25, 2023
Merged

Convert updates to protocol/message data types #253

merged 20 commits into from
Jan 25, 2023

Commits on Jan 24, 2023

  1. Convert updates to protocol/message data types

    Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    bf3e94b View commit details
    Browse the repository at this point in the history

  2. Prefer 'stage' to 'event' to avoid vocab conflicts

    Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    4ba460f View commit details
    Browse the repository at this point in the history

  3. Re-use old field numbers 

    Nothing ever shipped that used these fields.
    Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    c0403c7 View commit details
    Browse the repository at this point in the history

  4. Note that deleted field numbers are ok to reuse

    Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    bc20aae View commit details
    Browse the repository at this point in the history

  5. Avoid storing an Any in history

    Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    4dbb5d2 View commit details
    Browse the repository at this point in the history

  6. Fix go package name hint

    Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    2e86d5a View commit details
    Browse the repository at this point in the history

  7. Add fields to Accepted and Updated events 

    The worker will need to recreate an input message from the data
contained in these events.
    Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    8a15246 View commit details
    Browse the repository at this point in the history

  8. Change Message.sequence_id to a oneof 

    Enables sequencing on event_id or command_id with strong typing.
    Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    920c13f View commit details
    Browse the repository at this point in the history

  9. Prefer the singluar Payload where possible

    Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    5589634 View commit details
    Browse the repository at this point in the history

  10. Normal field ordering: 1 before 2

    Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    566505c View commit details
    Browse the repository at this point in the history

  11. Add event sequencing ID to accept/reject events

    Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    3e2fc21 View commit details
    Browse the repository at this point in the history

  12. Fixes misspelled field name

    Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    bf04580 View commit details
    Browse the repository at this point in the history

  13. msg ID and seq ID fields on Accept/Reject messages 

    Needed for the server to build out the associated Accept/Reject history
event in the case that the original protocol information has been lost
(e.g. due to shard movement)
    Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    4352777 View commit details
    Browse the repository at this point in the history

  14. Back to plural Payloads

    Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    5da5b5b View commit details
    Browse the repository at this point in the history

  15. Comments for UpdateWorkflowExecutionLifecycleStage enum

    Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    df201af View commit details
    Browse the repository at this point in the history

  16. Rethinking the definition of Outcome 

    The possibility for an outcome to be incomplete is not present in the
protocol messages - it is only something that can happen with the RPC so
we move that indication up a level to the RPC response object. This also
prevents us from accidentally storing Incomplete{} as the outcome value
in an update completed event.
    Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    fea81d1 View commit details
    Browse the repository at this point in the history

  17. Add workflow task failed causes

    @alexshtin
    alexshtin authored and Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    9cb2092 View commit details
    Browse the repository at this point in the history

  18. Add ProtocolMessageCommand 

    Will be used to reference and sequence protocol messages from the
RespondWorkflowTaskCompletedRequest.Messages field.
    Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    5b6a4f9 View commit details
    Browse the repository at this point in the history

  19. Improved comment wording on UpdateWorkflowExecutionRequest.request

    Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    4ef1a9b View commit details
    Browse the repository at this point in the history

  20. Can't say 'required'

    Matt McShane committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    6c3fe16 View commit details
    Browse the repository at this point in the history