-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versioning docs touch-up #405
Conversation
@@ -68,6 +68,14 @@ message TaskQueueVersionSelection { | |||
message TaskQueueVersionInfo { | |||
// Task Queue info per Task Type. Key is the numerical value of the temporal.api.enums.v1.TaskQueueType enum. | |||
map<int32, TaskQueueTypeInfo> types_info = 1; | |||
|
|||
// Task Reachability is eventually consistent; there may be a delay until it converges to the most | |||
// accurate value but it is designed in a way to take the more conservative side until it converges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clarify what "conservative" means?
// Task Reachability is eventually consistent; there may be a delay until it converges to the most | ||
// accurate value but it is designed in a way to take the more conservative side until it converges. | ||
// Note: future activities who inherit their workflow's Build ID but not its Task Queue will not be | ||
// accounted for reachability as server cannot not know if they'll happen as they do not use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cannot not
// (by running in the same Task Queue or explicitly setting the | ||
// `inherit_build_id` flag.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"by running in the same Task Queue"
Is that always the case, if they use the same task queue they always inherit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, I changed the test to not get involved in that too much. from the API perspective we only look at the passed boolean. It's SDK's responsibility to send the right default value based on the task queue used.
// Target Build ID must be compatible with the Source Build ID; that is it | ||
// must be able to process event histories generation by Source Build ID. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this comment. Can you clarify compatible (patch api..)?
// Redirect rules should only be used when it's desired to move open workflows from one Build ID to | ||
// another compatible Build ID. You are responsible to make sure the target Build ID of a redirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make clear they affect all running workflows not only new ones...
Co-authored-by: David Reiss <david@temporal.io>
Co-authored-by: David Reiss <david@temporal.io>
Co-authored-by: David Reiss <david@temporal.io>
Co-authored-by: David Reiss <david@temporal.io>
Co-authored-by: David Reiss <david@temporal.io>
Co-authored-by: David Reiss <david@temporal.io>
What changed?
Some improvements to versioning docs.
Why?
Breaking changes
Server PR