Add callable workflow for only building the server image #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
force-pushed
the
just-build-image-workflow
branch
16 times, most recently
from
e9bbde3
to
2652c1d
Compare
dnr
reviewed
Nov 24, 2022
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v1 | ||
|
|
||
| - name: Build Server Image |
There was a problem hiding this comment.
is there any way to share more of this with docker.yml?
There was a problem hiding this comment.
They will be combined later by @mindaugasrukas
Sushisource
force-pushed
the
just-build-image-workflow
branch
7 times, most recently
from
cba69fa
to
e2a33f4
Compare
Sushisource
force-pushed
the
just-build-image-workflow
branch
5 times, most recently
from
239c603
to
2ccc748
Compare
Sushisource
force-pushed
the
just-build-image-workflow
branch
14 times, most recently
from
d9ee887
to
b14fae5
Compare
Sushisource
force-pushed
the
just-build-image-workflow
branch
from
b14fae5
to
d2ce63b
Compare
|
This is now working as used by temporalio/temporal#3627 |
mindaugasrukas
approved these changes
Dec 7, 2022
Comment on lines
+17
to
+20
| # Git info is needed for Go build to attach VCS information properly. | ||
| # See the `buildvcs` Go flag: https://pkg.go.dev/cmd/go | ||
| COPY ./.git ./.git | ||
| COPY ./.gitmodules ./.gitmodules |
There was a problem hiding this comment.
We can leave this for now.
I'm curious to know how we use that buildvcs information.
There was a problem hiding this comment.
The info is passed through to some internal variables that are used in places like CLI info:
https://github.com/temporalio/temporal/blob/af9130dcdbede1a8983069fde69d7c139d9d7b22/common/build/build.go#L42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a workflow which can be called by other repos to just build a docker image of server, so that they can use it for testing a certain commit, etc, without needing a published image.
Draft while working through using it from the server repo w/ sdk-features.