Fix handover callback (#3847)

temporalio · Jan 26, 2023 · 5c23836 · 5c23836
1 parent 1c84aad
commit 5c23836
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 27 deletions.
diff --git a/service/history/historyEngine.go b/service/history/historyEngine.go
@@ -301,7 +301,7 @@ func (e *historyEngineImpl) registerNamespaceStateChangeCallback() {
 
 	e.shard.GetNamespaceRegistry().RegisterStateChangeCallback(e, func(ns *namespace.Namespace, deletedFromDb bool) {
 		if e.shard.GetClusterMetadata().IsGlobalNamespaceEnabled() {
-			e.shard.UpdateHandoverNamespaces(ns, deletedFromDb)
+			e.shard.UpdateHandoverNamespace(ns, deletedFromDb)
 		}
 
 		if deletedFromDb {

diff --git a/service/history/shard/context.go b/service/history/shard/context.go
@@ -103,7 +103,7 @@ type (
 		// TODO: deprecate UpdateNamespaceNotificationVersion in v1.21 and remove
 		// NamespaceNotificationVersion from shardInfo proto blob
 		UpdateNamespaceNotificationVersion(namespaceNotificationVersion int64) error
-		UpdateHandoverNamespaces(ns *namespace.Namespace, deletedFromDb bool)
+		UpdateHandoverNamespace(ns *namespace.Namespace, deletedFromDb bool)
 
 		AppendHistoryEvents(ctx context.Context, request *persistence.AppendHistoryNodesRequest, namespaceID namespace.ID, execution commonpb.WorkflowExecution) (int, error)
 

diff --git a/service/history/shard/context_impl.go b/service/history/shard/context_impl.go
@@ -578,11 +578,17 @@ func (s *ContextImpl) UpdateNamespaceNotificationVersion(namespaceNotificationVe
 	return nil
 }
 
-func (s *ContextImpl) UpdateHandoverNamespaces(ns *namespace.Namespace, deletedFromDb bool) {
+func (s *ContextImpl) UpdateHandoverNamespace(ns *namespace.Namespace, deletedFromDb bool) {
 	nsName := ns.Name()
+	// NOTE: replication state field won't be replicated and currently we only update a namespace
+	// to handover state from active cluster, so the second condition will always be true. Adding
+	// it here to be more safe in case above assumption no longer holds in the future.
+	isHandoverNamespace := ns.IsGlobalNamespace() &&
+		ns.ActiveInCluster(s.GetClusterMetadata().GetCurrentClusterName()) &&
+		ns.ReplicationState() == enums.REPLICATION_STATE_HANDOVER
 
 	s.wLock()
-	if deletedFromDb {
+	if deletedFromDb || !isHandoverNamespace {
 		delete(s.handoverNamespaces, ns.Name())
 		s.wUnlock()
 		return
@@ -595,23 +601,15 @@ func (s *ContextImpl) UpdateHandoverNamespaces(ns *namespace.Namespace, deletedF
 		maxReplicationTaskID = pendingMaxReplicationTaskID
 	}
 
-	// NOTE: replication state field won't be replicated and currently we only update a namespace
-	// to handover state from active cluster, so the second condition will always be true. Adding
-	// it here to be more safe in case above assumption no longer holds in the future.
-	if ns.IsGlobalNamespace() &&
-		ns.ActiveInCluster(s.GetClusterMetadata().GetCurrentClusterName()) &&
-		ns.ReplicationState() == enums.REPLICATION_STATE_HANDOVER {
-
-		if handover, ok := s.handoverNamespaces[nsName]; ok {
-			if handover.NotificationVersion < ns.NotificationVersion() {
-				handover.NotificationVersion = ns.NotificationVersion()
-				handover.MaxReplicationTaskID = maxReplicationTaskID
-			}
-		} else {
-			s.handoverNamespaces[nsName] = &namespaceHandOverInfo{
-				NotificationVersion:  ns.NotificationVersion(),
-				MaxReplicationTaskID: maxReplicationTaskID,
-			}
+	if handover, ok := s.handoverNamespaces[nsName]; ok {
+		if handover.NotificationVersion < ns.NotificationVersion() {
+			handover.NotificationVersion = ns.NotificationVersion()
+			handover.MaxReplicationTaskID = maxReplicationTaskID
+		}
+	} else {
+		s.handoverNamespaces[nsName] = &namespaceHandOverInfo{
+			NotificationVersion:  ns.NotificationVersion(),
+			MaxReplicationTaskID: maxReplicationTaskID,
 		}
 	}
 

diff --git a/service/history/shard/context_mock.go b/service/history/shard/context_mock.go