Skip to content

Commit

Permalink
Remove unused Temporal interface (#3761)
Browse files Browse the repository at this point in the history
  • Loading branch information
MichaelSnowden authored Dec 23, 2022
1 parent 86e9d32 commit ba2d711
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 14 deletions.
15 changes: 2 additions & 13 deletions host/onebox.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,17 +76,6 @@ import (
"go.temporal.io/server/temporal"
)

// Temporal hosts all of temporal services in one process
type Temporal interface {
Start() error
Stop()
GetAdminClient() adminservice.AdminServiceClient
GetFrontendClient() workflowservice.WorkflowServiceClient
GetHistoryClient() historyservice.HistoryServiceClient
GetExecutionManager() persistence.ExecutionManager
RefreshNamespaceCache()
}

type (
temporalImpl struct {
frontendService *frontend.Service
Expand Down Expand Up @@ -168,8 +157,8 @@ type (
listenHostPort string
)

// NewTemporal returns an instance that hosts full temporal in one process
func NewTemporal(params *TemporalParams) *temporalImpl {
// newTemporal returns an instance that hosts full temporal in one process
func newTemporal(params *TemporalParams) *temporalImpl {
testDCClient := newTestDCClient(dynamicconfig.NewNoopClient())
for k, v := range params.DynamicConfigOverrides {
testDCClient.OverrideValue(k, v)
Expand Down
2 changes: 1 addition & 1 deletion host/test_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ func NewCluster(options *TestClusterConfig, logger log.Logger) (*TestCluster, er
logger.Fatal("Failed to start pprof", tag.Error(err))
}

cluster := NewTemporal(temporalParams)
cluster := newTemporal(temporalParams)
if err := cluster.Start(); err != nil {
return nil, err
}
Expand Down

0 comments on commit ba2d711

Please sign in to comment.