Skip to content

Commit

Permalink
Disable eager activities for Python 0.1a1, 0.1a2, and0.1b1 too (#3793)
Browse files Browse the repository at this point in the history
  • Loading branch information
bergundy authored Jan 10, 2023
1 parent 3e31880 commit ea893d1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion service/frontend/overrides.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func NewOverrides() *Overrides {
}

func (o *Overrides) shouldForceDisableEagerDispatch(sdkName, sdkVersion string) bool {
if sdkName == headers.ClientNamePythonSDK && sdkVersion == "0.1b2" {
if sdkName == headers.ClientNamePythonSDK && (sdkVersion == "0.1a1" || sdkVersion == "0.1a2" || sdkVersion == "0.1b1" || sdkVersion == "0.1b2") {
return true
} else if sdkName == headers.ClientNameTypeScriptSDK {
ver, err := semver.Parse(sdkVersion)
Expand Down
2 changes: 1 addition & 1 deletion service/frontend/overrides_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ func TestDisableEagerActivityDispatchForBuggyClients(t *testing.T) {
{sdkName: headers.ClientNameGoSDK, sdkVersion: "1.18.1", eagerAllowed: true},
{sdkName: headers.ClientNameTypeScriptSDK, sdkVersion: "1.4.1", eagerAllowed: false},
{sdkName: headers.ClientNameTypeScriptSDK, sdkVersion: "1.4.4", eagerAllowed: true},
{sdkName: headers.ClientNamePythonSDK, sdkVersion: "0.1a1", eagerAllowed: false},
{sdkName: headers.ClientNamePythonSDK, sdkVersion: "0.1b2", eagerAllowed: false},
{sdkName: headers.ClientNamePythonSDK, sdkVersion: "0.1b1", eagerAllowed: true},
{sdkName: headers.ClientNamePythonSDK, sdkVersion: "0.1b3", eagerAllowed: true},
}
for _, testCase := range cases {
Expand Down

0 comments on commit ea893d1

Please sign in to comment.