Make staticcheck great again #3103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
force-pushed
the
fix/enable-staticcheck
branch
from
d412f0d
to
4482a59
Compare
dnr
reviewed
Jul 14, 2022
| @@ -40,7 +40,7 @@ func NewDataBlob(data []byte, encodingTypeStr string) *commonpb.DataBlob { | |||
| encodingType, ok := enumspb.EncodingType_value[encodingTypeStr] | |||
| if !ok || (enumspb.EncodingType(encodingType) != enumspb.ENCODING_TYPE_PROTO3 && | |||
| enumspb.EncodingType(encodingType) != enumspb.ENCODING_TYPE_JSON) { | |||
| panic(fmt.Sprintf("Invalid encoding: \"%v\"", encodingTypeStr)) | |||
| panic(fmt.Sprintf("Invalid encoding: %v", encodingTypeStr)) | |||
There was a problem hiding this comment.
I thought about it but I don't like %q. Because everytime we log the error in JSON logger (which is default) it gets only worse.
alexshtin
force-pushed
the
fix/enable-staticcheck
branch
2 times, most recently
from
ba838d9
to
5aa58a7
Compare
dnr
reviewed
Jul 14, 2022
| @@ -1209,32 +1212,6 @@ func (e *MutableStateImpl) DeleteUserTimer( | |||
| return nil | |||
| } | |||
|
|
|||
| // nolint:unused | |||
There was a problem hiding this comment.
hey, I removed this first in #3055 🙂
| @@ -4566,7 +4543,7 @@ func (e *MutableStateImpl) createCallerError( | |||
| return serviceerror.NewInvalidArgument(msg) | |||
| } | |||
|
|
|||
| func (_ *MutableStateImpl) unixNanoToTime( | |||
| func (*MutableStateImpl) unixNanoToTime( | |||
There was a problem hiding this comment.
move this into common/primitives/timestamp or common/util?
There was a problem hiding this comment.
3 usages of this function are:
e.unixNanoToTime(now.UnixNano())🤦
alexshtin
force-pushed
the
fix/enable-staticcheck
branch
from
5aa58a7
to
e3b009f
Compare
dnr
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Make staticcheck great again.
Why?
To enable automatic static analysis.
How did you test it?
make staticcheckPotential risks
No risks.
Is hotfix candidate?
No.