Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename metrics.Handler to avoid name stuttering #3713

Merged
merged 5 commits into from
Dec 16, 2022
Merged

Rename metrics.Handler to avoid name stuttering #3713

merged 5 commits into from
Dec 16, 2022

Conversation

mindaugasrukas
Copy link
Contributor

What changed?
Renamed metrics.MetricsHandler to metrics.Handler and related metrics types.

Why?
To avoid name stuttering.

How did you test it?
CI

Potential risks
None

Is hotfix candidate?
No

@mindaugasrukas mindaugasrukas requested a review from a team as a code owner December 15, 2022 06:58
alexshtin
alexshtin approved these changes Dec 15, 2022
View reviewed changes
common/metrics/otel_metrics_handler_test.go Outdated Show resolved Hide resolved
common/metrics/runtime.go Outdated Show resolved Hide resolved
yux0
yux0 approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@yux0 yux0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this change.

@mindaugasrukas mindaugasrukas merged commit 0b4df6a into temporalio:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexshtin alexshtin alexshtin approved these changes

@yux0 yux0 yux0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mindaugasrukas @alexshtin @yux0