Improve archival_test #3719
Merged
Improve archival_test #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
The archival integration test logic changed. Previously, it only checked for history and required the mutable state to be deleted. Now, it doesn't verify if the mutable state is deleted because that's done later, and it checks for both history and visibility archival records.
Why?
I made these changes because this is a more robust test, and it also will make it easier to adapt this test to durable archival, which does not delete records at the same time it archives them.
How did you test it?
I ran it with
-count 5. I also commented out the archival methods and verified that the tests failed with those methods commented out.Potential risks
Just test.
Is hotfix candidate?
No