Fix bug not setting CanSkipVisibilityArchival #3721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
force-pushed
the
snowden/fix-set-skip-vis-archival-flag
branch
from
454b1d4
to
2dc133c
Compare
yycptt
approved these changes
Dec 16, 2022
| @@ -35,6 +35,7 @@ import ( | |||
| "go.temporal.io/api/serviceerror" | |||
|
|
|||
| enumsspb "go.temporal.io/server/api/enums/v1" | |||
|
|
|||
There was a problem hiding this comment.
nit: this empty line can be remove, they are all server imports.
There was a problem hiding this comment.
Fixed, thanks!
MichaelSnowden
force-pushed
the
snowden/fix-set-skip-vis-archival-flag
branch
from
2dc133c
to
df68bd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We now set the CanSkipVisibilityArchival flag when creating archival queue tasks.
Why?
This was a bug. We need to set this flag when using durable archival so that we don't archive visibility twice.
How did you test it?
I added a statement in the unit test and verified that the test failed before this change.
Potential risks
Not used in prod yet.
Is hotfix candidate?
No