Fix bug where we return nil when there's an error in the archival queue #3723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
commented
Dec 17, 2022
| err = taskGenerator.GenerateDeleteHistoryEventTask(*closeTime, true) | ||
| if err != nil { | ||
| return nil | ||
| return err |
There was a problem hiding this comment.
This is the bug we're fixing. The rest of this is just adding additional test coverage.
yycptt
reviewed
Dec 19, 2022
MichaelSnowden
force-pushed
the
snowden/fix-return-nil-err
branch
from
9045d59
to
aa4788b
Compare
yycptt
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This PR fixes a bug (on line 253) where we returned nil when there was an error generating the deletion timer task.
Why?
This is a bug.
How did you test it?
I added a test that verifies that we return that error when it occurs. I also verified that the test fails before this change. I also added 100% test coverage to this file to catch any other potential bugs.
Potential risks
None
Is hotfix candidate?
No