Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove scheduled and started events from transient workflow task info #3736

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Remove scheduled and started events from transient workflow task info #3736

merged 2 commits into from
Dec 20, 2022

Conversation

alexshtin
Copy link
Member

What changed?
Remove scheduled and started events from transient workflow task info.

Why?
Fields were replaced by HistorySuffix and deprecated in previous release.

How did you test it?
Existing tests.

Potential risks
No risks.

Is hotfix candidate?
No.

@alexshtin alexshtin requested a review from a team as a code owner December 20, 2022 08:55
MichaelSnowden
MichaelSnowden reviewed Dec 20, 2022
View reviewed changes
Copy link
Contributor

@MichaelSnowden MichaelSnowden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this backward compatible? Existing TransientWorkflowTaskInfos without this field populated will now show no history events. In essence, I'm wondering if these info protos are persisted anywhere, and, if so, how will they be migrated? If they aren't persisted then LGTM

@yycptt
Copy link
Member

yycptt commented Dec 20, 2022

Is this backward compatible? Existing TransientWorkflowTaskInfos without this field populated will now show no history events. In essence, I'm wondering if these info protos are persisted anywhere, and, if so, how will they be migrated? If they aren't persisted then LGTM

My understanding is: this info is not persisted and existing logic already does dual write.
https://github.com/temporalio/temporal/pull/3736/files#diff-dbe8e0ccf13b06f33995a72a7fe0585be57fb7fb052c22f4f7383d3d3a2abf35L734

@alexshtin alexshtin merged commit 0ad773b into temporalio:master Dec 20, 2022
@alexshtin alexshtin deleted the feature/remove-scheduled-started branch December 20, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelSnowden MichaelSnowden MichaelSnowden left review comments

@yycptt yycptt yycptt approved these changes

@mmcshane mmcshane Awaiting requested review from mmcshane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexshtin @yycptt @MichaelSnowden