Better SQL query splitter #3791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
reviewed
Jan 13, 2023
rodrigozhou
force-pushed
the
better-query-splitter
branch
from
1df7ae8
to
62709fb
Compare
|
Could we use a library for this? The code here seems pretty complicated. |
|
@MichaelSnowden I did a quick search before, and I didn't find anything for our use case. |
rodrigozhou
force-pushed
the
better-query-splitter
branch
2 times, most recently
from
be4ca7d
to
ad885d7
Compare
alexshtin
approved these changes
Jan 24, 2023
rodrigozhou
force-pushed
the
better-query-splitter
branch
from
ad885d7
to
4bad144
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Implemented a better SQL query splitter. It splits the statements taking into consideration
BEGIN/ENDblocks.Why?
The current algorithm simply splits by semicolon (
;), which would lead to wrong query statements when there are more complex statements that containsBEGIN/ENDblocks (eg: when creating a trigger).How did you test it?
Wrote unit tests.
Potential risks
No issues, it parses the existing SQL files correctly.
Is hotfix candidate?
No.