Fix SQL NPE after connection is closed #3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stopped setting
factory.mainDBConntonullwhen the last connection is closed so that a NullPointerException is not generated if this connection is used again after close.Added tests for MySQL and Postgresql to confirm that the underlying persistence layer library will return a useful error message.
Tests were not added for Cassandra because it uses a different
factorythat was not modified.Tests were not added for SQLite because at least one connection is always open until the server is shut down.
Fixes #3708
Why?
How did you test it?
Potential risks
Is hotfix candidate?