Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eager workflow dispatch #3835
Eager workflow dispatch #3835
Changes from all commits
ea6b281
5f23b7c
bb221c7
c3a4cd9
e8b8fba
fa4dccf
4e49875
38f628e
fc50446
15158f9
cc64258
06aebdc
f32e716
bb00ebe
6394cbb
8dba7ff
593a669
a01484b
7dae88e
9a3a16e
41296fc
65f9726
efece49
f23a706
ab77d10
e0a69c2
efd06d7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the first usage of
startRequest.StartRequest
that I see in this function, so I'm worried about potential NPEs. How do we know this is always non-nil?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't, we count on this request to be validated before this method is called.