Add explicit per-namespace rate limit to schedules #3838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Jan 26, 2023
service/worker/scheduler/fx.go
Outdated
| func (s *workerComponent) activities(name namespace.Name, id namespace.ID) *activities { | ||
| func (s *workerComponent) activities(name namespace.Name, id namespace.ID, workerFactor float64) *activities { | ||
| localRPS := func() float64 { | ||
| return s.globalNSStartWorkflowRPS(name.String()) * workerFactor |
There was a problem hiding this comment.
Can we not introduce this workerFactor? I think it might be more clear here to calculate it as:
localRPS = multiplicity * (globalRPS / totalWorkerCount).
There was a problem hiding this comment.
So you want to pass in multiplicity and total and do the division inside here? I guess that's fine too
| } | ||
| for { | ||
| var res schedspb.StartWorkflowResponse | ||
| err := workflow.ExecuteLocalActivity(ctx, s.a.StartWorkflow, req).Get(s.ctx, &res) |
There was a problem hiding this comment.
if this keep happening, will this blow up the history size?
There was a problem hiding this comment.
It happens at most once, that's what CompletedRateLimitSleep is for
yiminc
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add explicit per-namespace rate limit to schedule start workflow actions.
Why?
Server operators might like to be able to limit the number of workflows started by schedules, to avoid overloading the rest of the cluster if the feature is misused.
How did you test it?
New integration test
Potential risks
Is hotfix candidate?