Tune linters #3848
Merged
Tune linters #3848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
commented
Jan 26, 2023
Comment on lines
+143
to
+144
| # update-linters is not included because in CI linters are run by github actions. | ||
| ci-update-tools: update-goimports update-mockgen update-proto-plugins update-proto-linters |
There was a problem hiding this comment.
This saves about 10s of build time because linters are not getting installed on Buildkite now.
mindaugasrukas
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Tune linter config and
Makefile.Why?
Make developer experience better.
How did you test it?
Run on Buildkite.
Potential risks
No risks.
Is hotfix candidate?
No.