Conditionally register archival category #3867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Jan 30, 2023
MichaelSnowden
force-pushed
the
snowden/archival-category-global
branch
from
7deeb6c
to
582442b
Compare
MichaelSnowden
added a commit
that referenced
this pull request
Jan 31, 2023
MichaelSnowden
added a commit
that referenced
this pull request
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We now only register the archival category when archival is enabled.
Why?
Because if this category exists when the archival queue processor isn't running, our code will panic when NotifyNewTasks is run.
How did you test it?
I added an assertion in a unit test.
Potential risks
This may interfere with tiered storage.
Is hotfix candidate?
No