Merge custom search attributes from index name with empty string key #3877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Merge custom search attributes from the index name key with the empty string key in
searchattribute.Manager.GetSearchAttributes.Why?
There was a check to handle it in the search attribute validator, but there are many more calls to
GetSearchAttributesin the codebase. In order for than to be backwards compatible, I'm merging with the contents in the empty string key.How did you test it?
Existing tests.
Potential risks
Unlikely to have issue. The new index name key should be empty, so merging with the contents in the empty string key should be no-op.
One situation that might have issue is if the user is using Elasticsearch and there's the empty string key in cluster metadata. This might lead to unexpected results.
Is hotfix candidate?
No.