Allow setting cluster Id explicitly #3883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feedmeapples
force-pushed
the
customize-cluster-id
branch
from
176c593
to
f8bafed
Compare
feedmeapples
commented
Feb 2, 2023
feedmeapples
force-pushed
the
customize-cluster-id
branch
from
c1ec996
to
de07eb0
Compare
feedmeapples
force-pushed
the
customize-cluster-id
branch
from
de07eb0
to
0b09907
Compare
feedmeapples
commented
Feb 3, 2023
feedmeapples
commented
Feb 3, 2023
feedmeapples
commented
Feb 3, 2023
yux0
reviewed
Feb 3, 2023
| @@ -104,6 +104,8 @@ type ( | |||
| InitialFailoverVersion int64 `yaml:"initialFailoverVersion"` | |||
| // Address indicate the remote service address(Host:Port). Host can be DNS name. | |||
| RPCAddress string `yaml:"rpcAddress"` | |||
| // Cluster ID allows to explicitly set the ID of the cluster. Optional. | |||
| ClusterID string `yaml:"-"` | |||
There was a problem hiding this comment.
will it load it from config? if yes, use yaml:"clusterId"
There was a problem hiding this comment.
it's intentionally ignored #3883 (comment)
This is used by Temporal single binary
yux0
approved these changes
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a config option that allows to explicitly set Cluster ID through config
Why?
allow to temporal CLI that runs in in-memory mode to persist the ID between runs
How did you test it?
manually + in tests with temporalio/cli#96
Potential risks
Is hotfix candidate?
no