Advanced visibility for SQLite #3895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
commented
Feb 3, 2023
| @@ -204,5 +204,7 @@ func buildDSNAttr(cfg *config.SQL) (url.Values, error) { | |||
| // assume pragma | |||
| parameters.Add("_pragma", fmt.Sprintf("%s=%s", key, value)) | |||
| } | |||
| // set time format | |||
| parameters.Add("_time_format", "sqlite") | |||
There was a problem hiding this comment.
This line to make the SQLite driver module to format datetime using a supported SQLite format for datetime. Previously, without this setting, it was using time.String() to write datetime to the table.
rodrigozhou
force-pushed
the
adv-vis-sqlite
branch
from
042de71
to
42950d8
Compare
alexshtin
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
Reviewed together with @rodrigozhou. Some minor issues needs to be addressed but generally LGTM.
rodrigozhou
force-pushed
the
adv-vis-sqlite
branch
from
42950d8
to
9c9062d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Implement SQLite query converter for advanced visibility.
Update
sqlite/visibility.goDB interface to advanced visibility.Why?
Support advanced visibility for SQLite.
How did you test it?
Existing tests.
Started local server, and ran samples with custom search attributes.
Potential risks
None, sqlite is supported only for dev, and mostly using in-memory database.
Is hotfix candidate?
No.