Fix fail of speculative workflow task #3898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Am I reading this correctly that speculative WFT failures will become durable and have the standard holy trinity of events? |
|
"holy trinity", I like this! Yes, they will be created. |
mmcshane
approved these changes
Feb 3, 2023
alexshtin
force-pushed
the
feature/fail-speculative-wt
branch
from
a273ae6
to
1ad9ac4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix fail of speculative workflow task. If speculative workflow task is failing, corresponding WTScheduled and WTStarted events are added (similar to WTCompleted), and next workflow task is created as transient.
Why?
Consistency with normal workflow task.
How did you test it?
Added new integration test.
Potential risks
No risks.
Is hotfix candidate?
No.