Fix backward compatibility with std visibility when doing search attribute operations #3907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
force-pushed
the
fix-back-comp-std-vis
branch
from
ede07a7
to
55e791c
Compare
alexshtin
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
When using standard visibility, return empty string index name (
"").For search attribute operations, when the index name is an empty string, run the same workflow as before (try to register to cluster metadata).
Why?
Backward compatibility with standard visibility.
How did you test it?
Start server with Cassandra, and tried to add search attributes.
Potential risks
None.
Is hotfix candidate?
No.