Fix MySQL visibility index for full text search #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
reviewed
Feb 9, 2023
| @@ -135,9 +135,9 @@ CREATE INDEX by_keyword_07 ON custom_search_attributes (namespace_id, Key | |||
| CREATE INDEX by_keyword_08 ON custom_search_attributes (namespace_id, Keyword08); | |||
| CREATE INDEX by_keyword_09 ON custom_search_attributes (namespace_id, Keyword09); | |||
| CREATE INDEX by_keyword_10 ON custom_search_attributes (namespace_id, Keyword10); | |||
| CREATE FULLTEXT INDEX by_text_01 ON custom_search_attributes (namespace_id, Text01); | |||
There was a problem hiding this comment.
Oh, now I understand why you added it here. Yes, apparently it won't work for FTS fields.
alexshtin
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Removing
namespace_idfrom MySQL full text search index.Why?
namespace_idcannot be included to the index since there's no easy way to enforce namespace id value with the actual query string to be matched.How did you test it?
Started server, and run workflows querying Text type search attribute. Checked that it return empty result when no word matches the content.
Potential risks
No risks.
Is hotfix candidate?
No.