Replicate custom search attributes aliases with namespace replication #3922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
approved these changes
Feb 9, 2023
Comment on lines
+167
to
+172
| Retention: task.Config.GetWorkflowExecutionRetentionTtl(), | ||
| HistoryArchivalState: task.Config.GetHistoryArchivalState(), | ||
| HistoryArchivalUri: task.Config.GetHistoryArchivalUri(), | ||
| VisibilityArchivalState: task.Config.GetVisibilityArchivalState(), | ||
| VisibilityArchivalUri: task.Config.GetVisibilityArchivalUri(), | ||
| CustomSearchAttributeAliases: task.Config.GetCustomSearchAttributeAliases(), |
There was a problem hiding this comment.
Thanks for fixing this!
But I wonder if there's a way to avoid this issue in the future?
I feel like every time a new field is added, it's prone have this same issue.
There was a problem hiding this comment.
Reflection? Do we need to do this deep copy at all?
At least we should be able to add test which check all fields using reflection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Replicate custom search attributes aliases with namespace replication.
Why?
Custom search attributes aliases must be replicated together with other namespace config fields.
How did you test it?
Elasticsearch integration tests running on top of SQL advanced visibility (upcomming PR).
Potential risks
No risks.
Is hotfix candidate?
No.