Add integration tests for eager workflow start #3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
force-pushed
the
eager-workflow-start-tests
branch
from
2cbe390
to
fee959d
Compare
yiminc
approved these changes
Feb 10, 2023
alexshtin
reviewed
Feb 10, 2023
Comment on lines
+80
to
+107
| func (s *integrationSuite) respondWorkflowTaskCompleted(task *workflowservice.PollWorkflowTaskQueueResponse, result interface{}) { | ||
| dataConverter := converter.GetDefaultDataConverter() | ||
| payloads, err := dataConverter.ToPayloads(result) | ||
| s.Require().NoError(err) | ||
| completion := workflowservice.RespondWorkflowTaskCompletedRequest{ | ||
| Namespace: s.namespace, | ||
| Identity: "test", | ||
| TaskToken: task.TaskToken, | ||
| Commands: []*commandpb.Command{{CommandType: enumspb.COMMAND_TYPE_COMPLETE_WORKFLOW_EXECUTION, Attributes: &commandpb.Command_CompleteWorkflowExecutionCommandAttributes{ | ||
| CompleteWorkflowExecutionCommandAttributes: &commandpb.CompleteWorkflowExecutionCommandAttributes{ | ||
| Result: payloads, | ||
| }, | ||
| }}}, | ||
| } | ||
| _, err = s.engine.RespondWorkflowTaskCompleted(NewContext(), &completion) | ||
| s.Require().NoError(err) | ||
| } | ||
|
|
||
| func (s *integrationSuite) pollWorkflowTaskQueue() *workflowservice.PollWorkflowTaskQueueResponse { | ||
| task, err := s.engine.PollWorkflowTaskQueue(NewContext(), &workflowservice.PollWorkflowTaskQueueRequest{ | ||
| Namespace: s.namespace, | ||
| TaskQueue: s.defaultTaskQueue(), | ||
| Identity: "test", | ||
| }) | ||
| s.Require().NotNil(task, "PollWorkflowTaskQueue response was empty") | ||
| s.Require().NoError(err) | ||
| return task | ||
| } |
There was a problem hiding this comment.
Other tests use TaskPoller which does the same thing. Can you use it too?
| return &taskqueuepb.TaskQueue{Name: name, Kind: enumspb.TASK_QUEUE_KIND_NORMAL} | ||
| } | ||
|
|
||
| func (s *integrationSuite) startEagerWorkflow(baseOptions workflowservice.StartWorkflowExecutionRequest) *workflowservice.StartWorkflowExecutionResponse { |
There was a problem hiding this comment.
Suggested change
| func (s *integrationSuite) startEagerWorkflow(baseOptions workflowservice.StartWorkflowExecutionRequest) *workflowservice.StartWorkflowExecutionResponse { | |
| func (s *integrationSuite) startEagerWorkflow(baseRequest *workflowservice.StartWorkflowExecutionRequest) *workflowservice.StartWorkflowExecutionResponse { |
Comment on lines
+42
to
+49
| func (s *integrationSuite) defaultWorkflowID() string { | ||
| return fmt.Sprintf("integration-%v", s.T().Name()) | ||
| } | ||
|
|
||
| func (s *integrationSuite) defaultTaskQueue() *taskqueuepb.TaskQueue { | ||
| name := fmt.Sprintf("integration-queue-%v", s.T().Name()) | ||
| return &taskqueuepb.TaskQueue{Name: name, Kind: enumspb.TASK_QUEUE_KIND_NORMAL} | ||
| } |
There was a problem hiding this comment.
Probably worth to move this to integrationbase.go. We should use them everywhere.
| } | ||
|
|
||
| func (s *integrationSuite) startEagerWorkflow(baseOptions workflowservice.StartWorkflowExecutionRequest) *workflowservice.StartWorkflowExecutionResponse { | ||
| options := baseOptions |
There was a problem hiding this comment.
Suggested change
| options := baseOptions | |
| request := &workflowservice.StartWorkflowExecutionRequest{} | |
| *request := *baseRequest |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that most of the E2E tests I wrote for this in the features repo should actually be integration tests.