Remove unnecessary aliasing/unaliasing of scheduled workflow search attributes #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
changed the title
alexshtin
commented
Feb 11, 2023
| if err != nil { | ||
| return err | ||
| } | ||
| if err := wh.validateSearchAttributes(unaliasedStartWorkflowSas, namespaceName); err != nil { |
There was a problem hiding this comment.
I actually don't like bellow lint message. I always do explicit error return. Because what it suggests looks like the function returns results of another function.
There was a problem hiding this comment.
Yeah, this contradicts the standard Go style of having the error path exit early and the happy path flow to the end of the function. Sometimes for short functions I might return a call directly but if there are other error returns I agree the last one should also be an error return for consistency
dnr
approved these changes
Feb 11, 2023
| @@ -3164,22 +3170,6 @@ func (wh *WorkflowHandler) DescribeSchedule(ctx context.Context, request *workfl | |||
| return err | |||
| } | |||
|
|
|||
| // map action search attributes | |||
There was a problem hiding this comment.
maybe just replace with a comment like
// Search attributes in the Action are already in external ("aliased") form. Do not alias them here.
| @@ -3070,7 +3071,12 @@ func (wh *WorkflowHandler) validateStartWorkflowArgsForSchedule( | |||
| return errIDReusePolicyNotAllowed | |||
| } | |||
|
|
|||
| if err := wh.validateSearchAttributes(startWorkflow.GetSearchAttributes(), namespaceName); err != nil { | |||
| // Unalias startWorkflow search attributes only for validation. Keep aliases in request. | |||
There was a problem hiding this comment.
Suggested change
| // Unalias startWorkflow search attributes only for validation. Keep aliases in request. | |
| // Unalias startWorkflow search attributes only for validation. Keep aliases in the request, because the request will be sent back to frontend to start workflows, which will unalias at that point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Remove unnecessary aliasing/unaliasing of scheduled workflow search attributes.
Why?
They are getting unaliases when workflow is actually started.
How did you test it?
Functional tests over sqlite.
Potential risks
No risks.
Is hotfix candidate?
No.