Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle namespace not found case in redirection interceptor #3947

Merged
merged 6 commits into from
Feb 16, 2023
Merged

Handle namespace not found case in redirection interceptor #3947

merged 6 commits into from
Feb 16, 2023

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Feb 13, 2023

What changed?

  • Handle namespace not found case in redirection interceptor

Why?

  • If namespace not found, redirection interceptor will use empty namespace name for it's logic, which will result in Namespace is empty. error from namespace cache.

How did you test it?

  • Tested locally.

Potential risks

Is hotfix candidate?

@yycptt yycptt requested a review from a team as a code owner February 13, 2023 23:37
@yycptt yycptt merged commit 0bb6884 into temporalio:master Feb 16, 2023
@yycptt yycptt deleted the fix-redirection-interceptor branch February 16, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yux0 yux0 yux0 approved these changes

@wxing1292 wxing1292 Awaiting requested review from wxing1292

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yycptt @yux0