e2e: add multiversion flag to generator #9829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williambanfield
commented
Dec 2, 2022
Do you mean this should be merged after all the other PRs you have open that're related to the E2E code? |
I mean that in terms of the multi-version feature, I don't foresee needing to make other changes to the Go code. The other e2e changes in my head are separate from this one and may require more changes to the Go. |
williambanfield
added
S:backport-to-v0.34.x
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
* add multiversion flag to generator * clarify flag comment (cherry picked from commit ac48630)
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
* add multiversion flag to generator * clarify flag comment (cherry picked from commit ac48630) # Conflicts: # test/e2e/generator/main.go
williambanfield
added a commit
that referenced
this pull request
Dec 6, 2022
williambanfield
added a commit
that referenced
this pull request
Dec 7, 2022
* add multiversion flag to generator * clarify flag comment (cherry picked from commit ac48630)
williambanfield
added a commit
that referenced
this pull request
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should be the last changes made directly to the Go e2e code. This adds a
multi-versionflag to the e2e test generator. When set with--multi-version <version-number>the e2e generator will create manifests with with<version-number>specified as the node version.The final piece of this group of changes will be setting this flag in the
v0.34.xbranch's invocation of thegeneratortool. The flag will be set dynamically by querying git for the latestv0.34.*tag.PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed