Bump version to 1.6.0 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgar-bonet
reviewed
Nov 26, 2023
There was a problem hiding this comment.
It makes sense to bump to at least 1.6. Maybe to 2.0 if introducing a behavior incompatible with previous versions, e.g. more tolerant parsing. In the end, I think the decision belongs to @tenox7.
|
I would prefer 1.6 rather than 2.0. I think I want to reserve 2.0 if we completely rewrite it in Go or Rust or something like that. |
tenox7
reviewed
Nov 27, 2023
hartwork
force-pushed
the
bump-version
branch
from
dace742
to
27dbc57
Compare
@tenox7 alright, re-targeted to 1.6.0 now. |
edgar-bonet
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the slight differences in behavior and the number of improvements maybe "2.0.0" will be a better fit that "1.5.3", so I went for that. Just an idea, and also demos a pull request where UI tests are affected.