Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace pkg/error with cockroachdb/errors #44

Merged
merged 2 commits into from
Apr 23, 2022
Merged

chore: replace pkg/error with cockroachdb/errors #44

merged 2 commits into from
Apr 23, 2022

Conversation

Thrimbda
Copy link
Member

resolve #27

to summerize, cockroachdb/errors is a drop-in replacement to pkg/errors and is still being maintained.

@gaocegege
Copy link
Member

Should we update the gomod?

@Thrimbda
Copy link
Member Author

Sure, I checked it out without thinking

@Thrimbda Thrimbda requested a review from gaocegege April 23, 2022 05:01
@Thrimbda
Copy link
Member Author

PTAL

@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

@gaocegege gaocegege merged commit 894664c into main Apr 23, 2022
@gaocegege gaocegege deleted the chore/replace-errors branch April 23, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
envd sprint board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

discussion(errors): Use github.com/cockroachdb/errors instead of pkg/errors
2 participants
@Thrimbda @gaocegege