Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tfjs to 0.0.5, which depends on tfjs-core 0.0.2 #12

Merged
merged 2 commits into from
Mar 20, 2018
Merged

Update tfjs to 0.0.5, which depends on tfjs-core 0.0.2 #12

merged 2 commits into from
Mar 20, 2018

Conversation

dsmilkov
Copy link
Contributor

@dsmilkov dsmilkov commented Mar 20, 2018 •
edited by nsthorat
Loading

This change is Reviewable

@dsmilkov dsmilkov requested review from nsthorat and caisq March 20, 2018 18:05
@dsmilkov dsmilkov changed the title Update tfjs to depend on tfjs-core 0.0.2 Update tfjs to 0.0.5, which depends on tfjs-core 0.0.2 Mar 20, 2018
@nsthorat
Copy link
Contributor

:lgtm_strong:

Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.

scripts/publish-npm.sh, line 29 at r1 (raw file):

set -e

BRANCH=`git rev-parse --abbrev-ref HEAD`

can we check the origin too?

git config --get remote.origin.url



---


*Comments from [Reviewable](https://reviewable.io:443/reviews/tensorflow/tfjs/12#-:-L83aa2CnDys5TDk_ZB8:b-jbsf8z)*
<!-- Sent from Reviewable.io -->

@dsmilkov
Copy link
Contributor Author

Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

scripts/publish-npm.sh, line 29 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

can we check the origin too?

git config --get remote.origin.url

Done.

Comments from Reviewable

@dsmilkov dsmilkov merged commit e68a66a into master Mar 20, 2018
@dsmilkov dsmilkov deleted the update-version branch March 20, 2018 20:19
nsthorat pushed a commit that referenced this pull request Aug 19, 2019
@nkreeger
Convert all assertions to actual JS messages and cleanup logging. (#12)
f196c27 
* Convert all assertions to actual JS messages and cleanup logging.

* Change description of constructor test.
nsthorat pushed a commit that referenced this pull request Aug 20, 2019
@tafsiri
update build to work better with jsdelivr. fix typo (#12)
a2568f0
@Hyodori04 Hyodori04 mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsthorat nsthorat Awaiting requested review from nsthorat

@caisq caisq Awaiting requested review from caisq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsmilkov @nsthorat