Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change diffing logic for the new release process. #2867

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

lina128
Copy link
Collaborator

@lina128 lina128 commented Mar 11, 2020

To prepare for the new release process. Change the diffing logic so that if PR is sent to a release branch, diff against that branch, not master.


This change is Reviewable

Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov, @lina128, @nsthorat, and @pyu10055)


cloudbuild.yml, line 17 at r1 (raw file):

  - 'COMMIT_SHA=$COMMIT_SHA'
  - 'BRANCH_NAME=$BRANCH_NAME'
  - 'BASE_BRANCH=$_BASE_BRANCH'

just confirming that _BASE_BRANCH is pre-populated by cloudbuid, is that right?

@lina128
Copy link
Collaborator Author

lina128 commented Mar 11, 2020

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov, @lina128, @nsthorat, and @pyu10055)

cloudbuild.yml, line 17 at r1 (raw file):

  - 'COMMIT_SHA=$COMMIT_SHA'
  - 'BRANCH_NAME=$BRANCH_NAME'
  - 'BASE_BRANCH=$_BASE_BRANCH'

just confirming that _BASE_BRANCH is pre-populated by cloudbuid, is that right?

Hi Daniel, that is right, it is documented here: https://cloud.google.com/cloud-build/docs/configuring-builds/substitute-variable-values
And I tested here, see CI log: https://pantheon.corp.google.com/cloud-build/builds/96e2d6be-b872-4ea8-8872-c1f211157a81?project=learnjs-174218

@lina128 lina128 merged commit 575bb2c into tensorflow:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants