Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor release script. #2921

Merged
merged 3 commits into from
Mar 18, 2020
Merged

Refactor release script. #2921

merged 3 commits into from
Mar 18, 2020

Conversation

lina128
Copy link
Collaborator

@lina128 lina128 commented Mar 17, 2020

The release process will change to

  1. which release unit (union, vis, react-native, or website),
  2. which phase. The release branch should be auto generated, following a pattern ${release_unit}_${release_version}.

This change is Reviewable

Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Wait for Nikhil as well.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov, @lina128, @nsthorat, and @pyu10055)


scripts/release.ts, line 222 at r1 (raw file):

    if (phaseInt !== 0) {
      // Phase0 should be published and release branch should have been created.
      const latestVersion = $(`npm view @tensorflow/${phases[0].packages[0]} dist-tags.latest`);

nit: use string concat (+) to break this string in 2 and keep 80 width, or move the cmd to a separate variable.

Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @lina128, @nsthorat, and @pyu10055)


scripts/release.ts, line 107 at r1 (raw file):

};

const TFJS = {

how about

const TFJS_RELEASE_UNIT: ReleaseUnit = {

here and below

@lina128
Copy link
Collaborator Author

lina128 commented Mar 18, 2020

Thank you for the comments, change done. Thank you @dsmilkov and @nsthorat!

@lina128 lina128 merged commit 284b352 into tensorflow:master Mar 18, 2020
@lina128 lina128 deleted the release branch March 23, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants