Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README.md #7

Merged
merged 5 commits into from
Mar 18, 2018
Merged

Improve README.md #7

merged 5 commits into from
Mar 18, 2018

Conversation

caisq
Copy link
Contributor

@caisq caisq commented Mar 18, 2018

This change is Reviewable

@dsmilkov
Copy link
Contributor

:lgtm_strong: Thank you


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


README.md, line 4 at r1 (raw file):
How about something similar to what's in : go/jstensorflow-staging

TensorFlow.js is a machine learning framework for JavaScript developers. It supports building, training and serving machine learning models in the browser using WebGL acceleration. You can import pre-trained TensorFlow SavedModels[link], as well as Keras models[link], for execution in the browser.


README.md, line 17 at r1 (raw file):

For more information on the APIs, follow the links to their respective
repositories, or visit [js.tensorflow.org](https://js.tensorflow.org).

How about putting this above the "This repository contains the logic and scripts..."


Comments from Reviewable

@caisq
Copy link
Contributor Author

caisq commented Mar 18, 2018

Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.


README.md, line 4 at r1 (raw file):

Previously, dsmilkov (Daniel Smilkov) wrote…

How about something similar to what's in : go/jstensorflow-staging

TensorFlow.js is a machine learning framework for JavaScript developers. It supports building, training and serving machine learning models in the browser using WebGL acceleration. You can import pre-trained TensorFlow SavedModels[link], as well as Keras models[link], for execution in the browser.

Done


README.md, line 17 at r1 (raw file):

TensorFlow.js is a machine learning framework for JavaScript developers. It supports building, training and serving machine learning models in the browser using WebGL acceleration. You can import pre-trained TensorFlow SavedModels[link], as well as Keras models[link], for execution in the browser.

Done


Comments from Reviewable

@nsthorat
Copy link
Contributor

:lgtm_strong:


Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.


README.md, line 3 at r1 (raw file):

# TensorFlow.js: Union Package

A part of the [TensorFlow](https://www.tensorflow.org) ecosystem,

Can we flip this?

TensorFlow.js is a JavaScript machine learning library for training and deploying machine learning models that is part of the larger TensorFlow ecosystem.

Note "JS" over "Web" (what PMs / marketing wants since we dont want to restrict ourselves to web)



---


*Comments from [Reviewable](https://beta.reviewable.io/reviews/tensorflow/tfjs/7#-:-L7tZE1JD7GxJc8AU3t0:b-jbsf8z)*
<!-- Sent from Reviewable.io -->

@caisq
Copy link
Contributor Author

caisq commented Mar 18, 2018

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.


README.md, line 3 at r1 (raw file):

TensorFlow ecosystem,

Done.


Comments from Reviewable

@caisq caisq merged commit d3cd1b1 into tensorflow:master Mar 18, 2018
easadler pushed a commit to easadler/tfjs that referenced this pull request Apr 12, 2018
Update readme with current and correct repository link
nsthorat pushed a commit that referenced this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants