Feature/typepayload #200
Merged
Feature/typepayload #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelskieglazki
requested review from
kirill-scherba,
kshokhin and
chernikovdmitry
angelskieglazki
added this to In Progress
in Teonet library, applications, controls and components
via automation
src/ev_mgr.c
Outdated
| // Start TCP proxy client | ||
| if(!(ke->tp->fd_client > 0)) | ||
| if(ke->tp->fd_client == 0) { |
There was a problem hiding this comment.
0 - валидный дескриптор же, обычно он stdin. Не валидный fd == -1
| if(ip_is_private(ips[i])) { | ||
| int ip_len = strlen(ips[i]) + 1; | ||
| memcpy(packet->ips + ptr, ips[i], ip_len); | ||
| ptr += ip_len; |
There was a problem hiding this comment.
Проверить что len * MAX_IP_STR_LEN > ptr
Ассертить если не, это ошибка которая много и очень неочевидно сломает
kshokhin
reviewed
Apr 5, 2021
src/ev_mgr.c
Outdated
| // Start TCP proxy client | ||
| if(!(ke->tp->fd_client > 0)) | ||
| if(!(ke->tp->fd_client > 0)) { |
There was a problem hiding this comment.
Suggested change
| if(!(ke->tp->fd_client > 0)) { | |
| if(ke->tp->fd_client < 0) { |
0 же валидный, а тут оно провалится
kshokhin
reviewed
Apr 6, 2021
| host_info_data *hid = teoGetHostInfo(event_manager, &hid_len); | ||
|
|
||
| char *full_type = teoGetFullAppTypeFromHostInfo(hid); | ||
| strncpy(packet->type, full_type, sizeof(packet->type)); |
There was a problem hiding this comment.
Здесь как-то хочется проверять, что full_type влезает целиком в packet->type
А что делать, если не влезает? Выкидывать лишние типы? Писать, сколько влезет?
Может тогда ограничить размер full_type? Или неограниченный размер для packet->type.
kshokhin
reviewed
Apr 6, 2021
src/net_com.c
Outdated
| // Parse command data | ||
| uint8_t *num_ip = rd->data; // Number of IPs | ||
| connect_r_packet_t *packet = rd->data; | ||
| printHexDump(packet, rd->data_len); |
There was a problem hiding this comment.
Это, наверное, стоит либо убрать, либо под флаг отладочный унести
…ent-peer net_core.c: skip packet if peer not found
ev_mgr.c: resolve dns name before connect to r-host
Teonet library, applications, controls and components
automation
moved this from In Progress
to Done
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#188